Skip to content

Conversation

@Logiquo
Copy link
Collaborator

@Logiquo Logiquo commented Jan 10, 2026

Contributor: Yongda Fan ([email protected])

Contribution Type: Processor

Description
IgnoreProcessor is a special processor to tell BaseDatset.set_task to exclude this column in the final SampleDataset data. This effectively allow us to disable a group of features for the same task, which can be useful for feature selection.

@Logiquo Logiquo requested a review from jhnwu3 January 10, 2026 17:33
Copy link
Collaborator

@jhnwu3 jhnwu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea a lot more than the hierarchical processor ideas/ other details. I also like the changes to the SampleBuilder as it's cleaner and less redundant it seems

Only 1 little thing to change is that we should add the IgnoreProcessor to the docs/ so there's a quick reference for it so users know they can do this.

@Logiquo Logiquo requested a review from jhnwu3 January 11, 2026 22:16
Copy link
Collaborator

@jhnwu3 jhnwu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Logiquo Logiquo added the component: processor Contribute a new processor to PyHealth label Jan 11, 2026
@Logiquo Logiquo merged commit 6cfa99e into sunlabuiuc:master Jan 11, 2026
1 check passed
@Logiquo Logiquo deleted the feat-select branch January 11, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: processor Contribute a new processor to PyHealth

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants